mik-laj commented on a change in pull request #5515: [AIRFLOW-4879] add
poll_interval and schema to PrestoHook
URL: https://github.com/apache/airflow/pull/5515#discussion_r319936757
##########
File path: airflow/hooks/presto_hook.py
##########
@@ -41,6 +61,11 @@ class PrestoHook(DbApiHook):
conn_name_attr = 'presto_conn_id'
default_conn_name = 'presto_default'
+ def __init__(self, *args, **kwargs):
+ super().__init__(*args, **kwargs)
+ self.poll_interval = kwargs.pop("poll_interval")
Review comment:
I prefer a list of parameters because it provides better IDE support. args
kwargs should only be used if another solution cannot be used. I would be happy
if you would add type annotations too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
