o-nikolas commented on code in PR #39212:
URL: https://github.com/apache/airflow/pull/39212#discussion_r1578255216
##########
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##########
@@ -400,7 +400,7 @@ def attempt_task_runs(self):
else:
task = run_task_response["tasks"][0]
self.active_workers.add_task(task, task_key, queue, cmd,
exec_config, attempt_number)
- self.queued(task_key, task.task_arn)
+ self.running_state(task_key, task.task_arn)
Review Comment:
Ooo, I see what you mean now, good catch! I suppose we could set a min
version, but instead I'll try call that new method in a try/catch and swallow
the exception. The only real consequence of that is that task adoption will not
work (but this is a nice to have and many executors don't support it), the code
to support that is what introduced this regression in the first place anyway.
So task adoption will only work in 2.10 forward, but the rest will be backwards
compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
