Taragolis commented on code in PR #39270:
URL: https://github.com/apache/airflow/pull/39270#discussion_r1580569241
##########
airflow/operators/python.py:
##########
@@ -350,6 +343,36 @@ def get_tasks_to_skip():
return condition
+def _load_pickle():
+ import pickle
+
+ return pickle
+
+
+def _load_dill():
+ try:
+ import dill
+ except ImportError:
+ raise AirflowException("Unable to import 'dill' make sure that it
installed.")
Review Comment:
My main point here give an advice to user as we do for other cases when
required package not installed, e.g. in providers with optional dependencies.
I do not have a personal preferences and we could do that by just use simple
logging, but personally for me Python's stacktrace it it pretty good when it
comes to the re-raising.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
