shahar1 commented on code in PR #39315:
URL: https://github.com/apache/airflow/pull/39315#discussion_r1584775094
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -2390,6 +2397,50 @@ def var_print(var_name):
return project_id, dataset_id, table_id
+ @GoogleBaseHook.fallback_to_default_project_id
+ def get_query_results(
+ self,
+ job_id: str,
+ location: str,
+ max_results: int | None = None,
Review Comment:
I followed the same naming conventions as in the Google API, which are also
used in other methods of this class.
I'd rather keep it `max_results` - its meaning should be quite clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
