shahar1 commented on code in PR #39315:
URL: https://github.com/apache/airflow/pull/39315#discussion_r1586490522
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -1035,31 +1057,45 @@ def execute(self, context: Context):
)
if not self.deferrable:
- self.log.info(
- "Fetching Data from %s.%s.%s max results: %s",
- self.table_project_id or hook.project_id,
- self.dataset_id,
- self.table_id,
- int(self.max_results),
- )
- if not self.selected_fields:
- schema: dict[str, list] = hook.get_schema(
+ if not self.job_id:
+ self.log.info(
+ "Fetching Data from %s.%s.%s max results: %s",
+ self.table_project_id or hook.project_id,
+ self.dataset_id,
+ self.table_id,
+ int(self.max_results),
Review Comment:
Good question, it's been like that in the other methods as well - probably
as an extra validation, but I agree that it feels odd. I replaced all
occurrences of `int(self.max_results)` to `self.max_results`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
