pankajkoti commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1587432202
##########
tests/system/providers/pinecone/example_pinecone_cohere.py:
##########
@@ -37,15 +36,15 @@
start_date=datetime(2023, 1, 1),
catchup=False,
) as dag:
-
- @setup
- @task
- def create_index():
- from airflow.providers.pinecone.hooks.pinecone import PineconeHook
-
- hook = PineconeHook()
- hook.create_index(index_name=index_name, dimension=768)
- time.sleep(60)
+ create_index = CreatePodIndexOperator(
+ task_id="create_index",
+ index_name=index_name,
+ dimension=768,
+ replicas=1,
+ shards=1,
+ pods=1,
+ pod_type="p1.x1",
Review Comment:
As I read the PR description I see that the system tests are failing due to
missing spec. What all are the missing specs that are required? If there are
some specs that are required, we should either mark those as required
positional args or if they are keyword args they should have default values
during the operator initialisation.
https://github.com/apache/airflow/blob/778e8c50b987176b15689bb681ac4c48d7a7805a/airflow/providers/pinecone/operators/pinecone.py#L109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
