pankajkoti commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1587600098
##########
tests/system/providers/pinecone/example_pinecone_openai.py:
##########
@@ -75,15 +74,15 @@
start_date=datetime(2023, 1, 1),
catchup=False,
) as dag:
-
- @setup
- @task
- def create_index():
- from airflow.providers.pinecone.hooks.pinecone import PineconeHook
-
- hook = PineconeHook()
- hook.create_index(index_name=index_name, dimension=1536)
Review Comment:
also since you're pointing that we need to use an operator instead of the
hook method, could you also please check if the hook needs some fixing?
If `hook.create_index(index_name=index_name, dimension=1536)` is no longer
working, we should check what is it that is breaking and that could be the real
fix. Is it missing args? Then those missing args should be added to the hook,
they could be positional args and we could show here in the example what values
those positional args could take. Or we could mark them as keyword args and
provide default values that are accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
