hussein-awala commented on code in PR #39348:
URL: https://github.com/apache/airflow/pull/39348#discussion_r1590163001
##########
airflow/providers/google/cloud/operators/kubernetes_engine.py:
##########
@@ -785,16 +786,16 @@ def fetch_cluster_info(self) -> tuple[str, str | None]:
self._ssl_ca_cert = cluster.master_auth.cluster_ca_certificate
return self._cluster_url, self._ssl_ca_cert
- def invoke_defer_method(self):
+ def invoke_defer_method(self, last_log_time: DateTime | None = None):
"""Redefine triggers which are being used in child classes."""
trigger_start_time = utcnow()
self.defer(
trigger=GKEStartPodTrigger(
- pod_name=self.pod.metadata.name,
- pod_namespace=self.pod.metadata.namespace,
+ pod_name=self.pod.metadata.name, # type: ignore[union-attr]
+ pod_namespace=self.pod.metadata.namespace, # type:
ignore[union-attr]
trigger_start_time=trigger_start_time,
- cluster_url=self._cluster_url,
- ssl_ca_cert=self._ssl_ca_cert,
+ cluster_url=self._cluster_url, # type: ignore[arg-type]
+ ssl_ca_cert=self._ssl_ca_cert, # type: ignore[arg-type]
Review Comment:
Why do you need to ignore `union-attr`? 🤔 I don't see any change that
impacts these parameters typing. Are you using the same MyPy version used in
the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
