Lee-W commented on code in PR #39295:
URL: https://github.com/apache/airflow/pull/39295#discussion_r1590888549
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -1066,3 +1083,6 @@ def execute(self, context: Context) -> None:
self.launch_notebook_job()
if self.wait_for_termination:
self.monitor_databricks_job()
+
+ def execute_complete(self, context: dict | None, event: dict):
+ _handle_deferrable_databricks_operator_completion(event, self.log)
Review Comment:
> Both do print similar logs. But, I do see there's a difference. Does it
need to be exactly the same implementation? If so, I can update it.
Ideally, yes. If it does not make the code super complicated.
> Although, it will raise error because of event["repair_run"] and I will
push a fix to use get so that it won't fail
Yep, `repair_run` is something I worried about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
