Lee-W commented on code in PR #39295:
URL: https://github.com/apache/airflow/pull/39295#discussion_r1590821159
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -1066,3 +1083,6 @@ def execute(self, context: Context) -> None:
self.launch_notebook_job()
if self.wait_for_termination:
self.monitor_databricks_job()
+
+ def execute_complete(self, context: dict | None, event: dict):
+ _handle_deferrable_databricks_operator_completion(event, self.log)
Review Comment:
It seems this function is not doing the same thing as its sync version 🤔
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -1066,3 +1083,6 @@ def execute(self, context: Context) -> None:
self.launch_notebook_job()
if self.wait_for_termination:
self.monitor_databricks_job()
+
+ def execute_complete(self, context: dict | None, event: dict):
Review Comment:
```suggestion
def execute_complete(self, context: dict | None, event: dict) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
