potiuk commented on a change in pull request #5979: [AIRFLOW-5373] Super fast 
pre-commit check for basic python2 compatib…
URL: https://github.com/apache/airflow/pull/5979#discussion_r320272299
 
 

 ##########
 File path: airflow/contrib/example_dags/example_qubole_operator.py
 ##########
 @@ -198,7 +198,7 @@ def compare_result(ds, **kwargs):
 
 /** Computes an approximation to pi */
 object SparkPi {
-  def main(args: Array[String]) {
+  def main(args) {
 
 Review comment:
   But I also remember about "you have one problem - introduce regexp - then 
you will have two problems" saying, so maybe it's even worth to write our own 
simple hook for that purpose if you think it's too "nerdy" with the regexp.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to