potiuk commented on a change in pull request #5979: [AIRFLOW-5373] Super fast 
pre-commit check for basic python2 compatib…
URL: https://github.com/apache/airflow/pull/5979#discussion_r320315671
 
 

 ##########
 File path: airflow/contrib/example_dags/example_qubole_operator.py
 ##########
 @@ -198,7 +198,7 @@ def compare_result(ds, **kwargs):
 
 /** Computes an approximation to pi */
 object SparkPi {
-  def main(args: Array[String]) {
+  def main(args) {
 
 Review comment:
   Actually if you are a perl programmer - then you will find the final result 
well.. refreshing :).
   
   I found that with (?x) extension you can not only write elegant and pretty 
"modular" code but also one that can contain comments (!).
   
   Also the exclusion rules can be rather elegant :).
   
   Surprisingly I have now regexp that I am actually proud of!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to