potiuk commented on a change in pull request #5944: [AIRFLOW-5362] Reorder
imports
URL: https://github.com/apache/airflow/pull/5944#discussion_r320278665
##########
File path: airflow/_vendor/nvd3/__init__.py
##########
@@ -16,14 +16,14 @@
'scatterChart', 'discreteBarChart', 'multiBarChart']
+from . import ipynb
+from .cumulativeLineChart import cumulativeLineChart
Review comment:
I think we should treat pylint + pydoc + import sort differently than whole
source file formatting change.
Black formatting (or whatever we choose) changes whole files. Introducing it
will basically rewrite ALL the lines of code we have. It will make it next to
impossible to merge in-progress PRs (and in some cases those changes will be
very difficult to resolve conflicts in those rebases).
On the other hand - sorting imports/adding pylint changes/updating
documentation is a very small and localised change to a small part of the code
- even if it is done in all files.
So changing import orders or adding docs is far less invasive than
formatting change (you can still easily merge other changes after you applied
them).
That's why I think it's worth to sort imports now separately. Even if
formatting tool will change the sort order later, it will be done together with
plenty of other changes for those files, so this will be pretty much no-issue
if also sorting order for imports change then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
