potiuk commented on a change in pull request #5944: [AIRFLOW-5362] Reorder
imports
URL: https://github.com/apache/airflow/pull/5944#discussion_r320459539
##########
File path: airflow/_vendor/nvd3/__init__.py
##########
@@ -16,14 +16,14 @@
'scatterChart', 'discreteBarChart', 'multiBarChart']
+from . import ipynb
+from .cumulativeLineChart import cumulativeLineChart
Review comment:
@ashb - If you refer to import ordering I think import sort is rather
non-invasive so I do not think it falls into the 'git blame' case. It is rather
localised and does not really affect the "meat" of the source code. But If you
refer to reformatting - I agree that re-formatting the code if we decide to do
it should be done as single big change and one that we can exclude with
--ignore-revs-file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
