jedcunningham commented on code in PR #38524:
URL: https://github.com/apache/airflow/pull/38524#discussion_r1594340292
##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -53,7 +53,7 @@ metadata:
release: {{ .Release.Name }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
heritage: {{ .Release.Service }}
- executor: {{ .Values.executor }}
+ executor: {{ trunc -63 .Values.executor }} # 3rd-party executor path can
be too long
Review Comment:
```suggestion
executor: {{ .Values.executor }}
```
No longer need to truncate right?
##########
chart/README.md:
##########
@@ -37,6 +37,9 @@ cluster using the [Helm](https://helm.sh) package manager.
## Features
* Supported executors: ``LocalExecutor``, ``CeleryExecutor``,
``KubernetesExecutor``, ``LocalKubernetesExecutor``,
``CeleryKubernetesExecutor``
+* Supported AWS executors with version ``8.20.0+``:
Review Comment:
```suggestion
* Supported AWS executors with AWS provider version ``8.21.0+``:
```
This landed in `8.21.0`, and let's be clear it's the provider version :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
