LipuFei commented on PR #38524: URL: https://github.com/apache/airflow/pull/38524#issuecomment-2107044378
> Thanks @LipuFei. Can you add tests for this also? Might be worth running around looking at LocalExecutor cases, as that's the most similar from the charts perspective I think. > > This [test case](https://github.com/apache/airflow/blob/d8fe51bcd266ae1ee8d5b77f19306d9453c41e2c/helm_tests/airflow_aux/test_basic_helm_chart.py#L524) should be updated as well. Can you harden it (make it fail if supported executors aren't all listed), or simplify it? > > I expect we may need some rbac changes as well for these executors? Is that something you've investigated? Hi @jedcunningham , I've updated the tests, including testing the supported executor. For AWS ECS Executor, there's no need for RBAC changes. I haven't tested the Batch Executor, but I think it works similarly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
