potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1596860844
########## tests/providers/openlineage/plugins/test_listener.py: ########## @@ -33,10 +33,20 @@ from airflow.providers.openlineage.plugins.listener import OpenLineageListener from airflow.providers.openlineage.utils.selective_enable import disable_lineage, enable_lineage from airflow.utils.state import State +from tests.test_utils.compat import AIRFLOW_V_2_10_PLUS from tests.test_utils.config import conf_vars pytestmark = pytest.mark.db_test +EXPECTED_TRY_NUMBER_1 = 1 if AIRFLOW_V_2_10_PLUS else 0 Review Comment: > Yes, but that was already taken car of in this [PR](https://github.com/apache/airflow/pull/39336/files#diff-776b432a685e8cc2a2ec0432aab9d9b22ca4e79a247debf0967a0a5802af09f2R49) i think. Well. But openlineage provider should (or not?) handle try_num before and after the change? Or the part where openlineage retrieves and uses try_num is part of the Airflow core? Because if it is in the provider then both - installing new openlineage provider in Airflow 2.9 wll not work, and installing old openlineage provider in Airlfow 2.10 (or 2.9.2 if we cherry-pick the change to 2.9) will not work either I am afraid. I thin - since this test is in the provider, the fact that we had to modify it for 2.9.1 is an indication that things will break. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
