Taragolis commented on code in PR #39513:
URL: https://github.com/apache/airflow/pull/39513#discussion_r1597426660
##########
tests/providers/amazon/aws/links/test_base_aws.py:
##########
@@ -203,7 +204,10 @@ def test_link_serialize(self):
"""Test: Operator links should exist for serialized DAG."""
self.create_op_and_ti(self.link_class, dag_id="test_link_serialize",
task_id=self.task_id)
serialized_dag = self.dag_maker.get_serialized_data()
- operator_extra_link =
serialized_dag["dag"]["tasks"][0]["__var"]["_operator_extra_links"]
+ if AIRFLOW_V_2_10_PLUS:
+ operator_extra_link =
serialized_dag["dag"]["tasks"][0]["__var"]["_operator_extra_links"]
+ else:
+ operator_extra_link =
serialized_dag["dag"]["tasks"][0]["_operator_extra_links"]
Review Comment:
DAG serialisation might change from version to version and I'm pretty sure
that is internal things which should not be use outside of the core. As far as
I remember and we force re-serialise DAG during the migration: `airflow db
migrate`
My point here, that we should use a bit different way for that kind of
tests, this one is for check integrity here - basically test fro check that we
do not forget to register extra links in provider specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
