potiuk commented on code in PR #39336: URL: https://github.com/apache/airflow/pull/39336#discussion_r1599850064
########## airflow/providers/dbt/cloud/CHANGELOG.rst: ########## @@ -28,6 +28,11 @@ Changelog --------- +main +..... + +In Airflow 2.10.0, we fix the way try_number works, so that it no longer returns different values depending on task instance state. Importantly, after the task is done, it no longer shows current_try + 1. Thus in 3.8.1 we patch this provider to fix try_number references so they no longer adjust for the old, bad behavior. + Review Comment: We are discussing this very thing in here with @kacpermuda and @mobuchowski : * https://github.com/apache/airflow/pull/39513#discussion_r1596005178 But also I need @dstandish to confirm if the SMTP change https://github.com/apache/airflow/pull/39513#discussion_r1596008489 - seem that the DBT change was good actually - as it handles back-compatibility nicely. This is the case for which I started to implement #39513 (for 2.9.0 compatibility) and follow-ups for 2.8 (#39606) and 2.7 (will be next) will be really helpful, because we are going to run the full suite of provider tests for past versions of airlfow once it is complete, so any kind of changes like that when we change both airflow and provider behaviour will have to be handled either as separate PRs or (if they are implemented as single PR) it will have to pass the back-compatibility tests with supported versions of Airflow. So those kind of changes will be caught very early in the process - in the PR that modifies tests of provider to accomodate for changed behaviour of Airflow (and it will need to be handled by the author). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
