eladkal commented on code in PR #39336:
URL: https://github.com/apache/airflow/pull/39336#discussion_r1597486765


##########
airflow/providers/dbt/cloud/CHANGELOG.rst:
##########
@@ -28,6 +28,11 @@
 Changelog
 ---------
 
+main
+.....
+
+In Airflow 2.10.0, we fix the way try_number works, so that it no longer 
returns different values depending on task instance state.  Importantly, after 
the task is done, it no longer shows current_try + 1. Thus in 3.8.1 we patch 
this provider to fix try_number references so they no longer adjust for the 
old, bad behavior.
+

Review Comment:
   Why is this here?
   How is this PR affect bdt provider?
   Providers are supported for older versions of Airflow as well. I'm out of 
context for what this PR achieves but I am not sure if this note in change log 
is the right place.
   
   What if I upgrade to provider version while I was on Airflow 2.7? Months 
later when I will upgrade to Airflow 2.10 I might miss that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to