kacpermuda commented on code in PR #39609: URL: https://github.com/apache/airflow/pull/39609#discussion_r1599979475
########## airflow/providers/openlineage/CHANGELOG.rst: ########## @@ -26,10 +26,10 @@ Changelog --------- -main +1.8.0 ..... -In Airflow 2.10.0, we fix the way try_number works, so that it no longer returns different values depending on task instance state. Importantly, after the task is done, it no longer shows current_try + 1. Thus in 1.7.2 we patch this provider to fix try_number references so they no longer adjust for the old, bad behavior. +In Airflow 2.10.0, the way try_number works changed, so that it no longer returns different values depending on task instance state. Importantly, after the task is done, it no longer shows current_try + 1. Thus in 1.8.0 version of this provider we fix try_number references so they no longer adjust for the old, bad behavior. This change makes all previous versions of OpenLineage provider (<1.8.0) incompatible with Airflow >= 2.10.0. Review Comment: I just modified the changelog to be more user friendly and simply point to the PR that introduced the change instead of summarizing it. There is already a `39336.significant.rst` - i can add some information about the influence on OL provider there, if you think it's a good idea. > I presume (as discussed before) 1.8 version of the provider will add (in the next PR) a way to handle try_number when installed on previous version of Airlfow. It's already [there](https://github.com/apache/airflow/blob/6bcec908cd27d691e97156a29c7243db9089e0f8/airflow/providers/openlineage/plugins/listener.py#L49), there is a function that determines whether we should subtract one from try_number based on Airflow version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
