eladkal commented on code in PR #39609: URL: https://github.com/apache/airflow/pull/39609#discussion_r1599870232
########## airflow/providers/openlineage/CHANGELOG.rst: ########## @@ -26,10 +26,10 @@ Changelog --------- -main +1.8.0 ..... -In Airflow 2.10.0, we fix the way try_number works, so that it no longer returns different values depending on task instance state. Importantly, after the task is done, it no longer shows current_try + 1. Thus in 1.7.2 we patch this provider to fix try_number references so they no longer adjust for the old, bad behavior. +In Airflow 2.10.0, the way try_number works changed, so that it no longer returns different values depending on task instance state. Importantly, after the task is done, it no longer shows current_try + 1. Thus in 1.8.0 version of this provider we fix try_number references so they no longer adjust for the old, bad behavior. This change makes all previous versions of OpenLineage provider (<1.8.0) incompatible with Airflow >= 2.10.0. Review Comment: If I am user that wants to upgrade. What is the action required from me? This text explain what was done to the code base. It does not explain what I need to do on upgrade ########## airflow/providers/openlineage/CHANGELOG.rst: ########## @@ -26,10 +26,10 @@ Changelog --------- -main +1.8.0 ..... -In Airflow 2.10.0, we fix the way try_number works, so that it no longer returns different values depending on task instance state. Importantly, after the task is done, it no longer shows current_try + 1. Thus in 1.7.2 we patch this provider to fix try_number references so they no longer adjust for the old, bad behavior. +In Airflow 2.10.0, the way try_number works changed, so that it no longer returns different values depending on task instance state. Importantly, after the task is done, it no longer shows current_try + 1. Thus in 1.8.0 version of this provider we fix try_number references so they no longer adjust for the old, bad behavior. This change makes all previous versions of OpenLineage provider (<1.8.0) incompatible with Airflow >= 2.10.0. Review Comment: If I am user that want to upgrade. What is the action required from me? This text explain what was done to the code base. It does not explain what I need to do on upgrade -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
