JDarDagran commented on code in PR #39614:
URL: https://github.com/apache/airflow/pull/39614#discussion_r1600000832
##########
airflow/providers/google/cloud/utils/openlineage.py:
##########
@@ -79,3 +92,265 @@ def get_identity_column_lineage_facet(
}
)
return column_lineage_facet
+
+
+@define
+class BigQueryJobRunFacet(BaseFacet):
Review Comment:
I don't have strong opinion on that, maybe @mobuchowski has.
AFAIK e.g. Spark custom facets don't have their JSON Schema specs defined
anywhere but I agree this could be stored somewhere. For sure we don't have
clear strategy what to do in such cases. If we still want to have JSON Schema -
I would put it in Google provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
