mobuchowski commented on code in PR #39614:
URL: https://github.com/apache/airflow/pull/39614#discussion_r1604667011
##########
airflow/providers/google/cloud/utils/openlineage.py:
##########
@@ -79,3 +92,265 @@ def get_identity_column_lineage_facet(
}
)
return column_lineage_facet
+
+
+@define
+class BigQueryJobRunFacet(BaseFacet):
Review Comment:
Provider specific facet should live in that provider. There's no gain in
having it somewhere else if it's not going to be emitted from some other
provider. It would only introduce potential versioning problem, and I think we
already have enough of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
