syedahsn commented on code in PR #38658:
URL: https://github.com/apache/airflow/pull/38658#discussion_r1602266425
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -617,6 +617,14 @@ def execute(self, context: Context) -> str | None:
job_id=self.job_id,
aws_conn_id=self.aws_conn_id,
waiter_delay=self.poll_interval,
+ waiter_max_attempts=self.max_polling_attempts,
+ )
+ if self.max_polling_attempts
Review Comment:
Wouldn't this be a better solution?
```
waiter_max_attempts=self.max_polling_attempts if self.max_polling_attempts
else 600
```
You can write a test where you provide a `max_polling_attempts`, and one
where you don't, and assert that the correct value is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
