syedahsn commented on code in PR #38658:
URL: https://github.com/apache/airflow/pull/38658#discussion_r1603749424
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -617,6 +617,14 @@ def execute(self, context: Context) -> str | None:
job_id=self.job_id,
aws_conn_id=self.aws_conn_id,
waiter_delay=self.poll_interval,
+ waiter_max_attempts=self.max_polling_attempts,
+ )
+ if self.max_polling_attempts
Review Comment:
Hmm that's a good point. In that case, maybe you can edit the Trigger code
to accept `None` (i.e. `waiter_max_attempts: int | None = 600`) as well, and do
(I also included the `waiter_delay` param as well)
```
waiter_max_attempts = waiter_max_attempts or 600
waiter_delay = waiter_delay or 30
```
You would then be able to pass just pass `max_polling_attempts` as is, and
the Trigger will handle the `None` case. What do you think about this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
