jonathan-ostrander commented on PR #39694: URL: https://github.com/apache/airflow/pull/39694#issuecomment-2118361921
@jedcunningham I'm not sure I understand your point about `OnFinishAction.KEEP_POD` or why the istio side car needs to be treated as a special case. Shouldn't that finish action be respected regardless of what's running in the pod? This doesn't change the behavior of `KubernetesPodOperator#process_pod_deletion` at all. It just changes the condition for a pod to be considered completed. I'm also excited by the introduction of sidecars, but sadly the GKE cluster that my team has airflow deployed on is currently on k8s version 1.27.x and our infra team doesn't have plans to upgrade to 1.29.x for a couple of months... We have a workaround which is to just enable the istio proxy (or just name the sidecar container `istio-proxy`) but this feels hacky considering we don't need istio. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
