dirrao commented on PR #39694: URL: https://github.com/apache/airflow/pull/39694#issuecomment-2119102465
> @ashb @dirrao That should happen when the pod is deleted. [According to the k8s docs, when a pod is marked for deletion the containers in the pod are issued a TERM with a 30 second grace period.](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination) Looks like we are not handling the case when it has sidecars. sidecars are still running event after base container exists. We can't judge the task state based on the pod phase. Why can't we base container state alone? `failed = not container_is_succeeded(remote_pod, self.base_container_name)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
