MaksYermak commented on PR #39711: URL: https://github.com/apache/airflow/pull/39711#issuecomment-2120222492
> > It is needed to fix the issue in acknowledged functionality in deferrable mode. > > If this is a bug fix then we should have a unit test to avoid regression Previously it was a problem in bad trigger design. In that design wasn't included that acknowledge ids exist only 10 seconds after pull. This creates an issue for users when the trigger passes successfully, but on PubSub service in Google Cloud they still have messages. It happens for users, because PubSub's trigger sleep after the pull command and then on the acknowledged stage trigger acknowledges the expired ID. I do not see how we can cover this case by unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
