jonathan-ostrander commented on code in PR #39694:
URL: https://github.com/apache/airflow/pull/39694#discussion_r1608686830
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -618,7 +615,8 @@ def await_pod_completion(
remote_pod = self.read_pod(pod)
if remote_pod.status.phase in PodPhase.terminal_states:
break
- if istio_enabled and container_is_completed(remote_pod,
container_name):
+ if container_is_completed(remote_pod, container_name):
+ self.log.info("Base container %s has completed",
container_name)
Review Comment:
What is the container that's being run in that case? [The default behavior
from k8s is to send a
`SIGTERM`](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination)
and other `STOP_SIGNAL`s configured on containers should be respected but I
wouldn't be surprised if you hit an edge case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
