mobuchowski commented on code in PR #39520:
URL: https://github.com/apache/airflow/pull/39520#discussion_r1608730794
##########
airflow/providers/openlineage/plugins/facets.py:
##########
@@ -39,15 +39,31 @@ class AirflowMappedTaskRunFacet(BaseFacet):
@classmethod
def from_task_instance(cls, task_instance):
- task = task_instance.task
- from airflow.providers.openlineage.utils.utils import
get_operator_class
+ from airflow.providers.openlineage.utils.utils import
get_fully_qualified_class_name
return cls(
mapIndex=task_instance.map_index,
-
operatorClass=f"{get_operator_class(task).__module__}.{get_operator_class(task).__name__}",
+ operatorClass=get_fully_qualified_class_name(task_instance.task),
)
+@define(slots=False)
+class AirflowJobFacet(BaseFacet):
+ """Composite Airflow job facet."""
+
+ taskTree: dict
+ taskGroups: dict
+ tasks: dict
+
+
+@define(slots=False)
+class AirflowStateRunFacet(BaseFacet):
+ """Airflow facet providing state information."""
+
+ dagRunState: str
+ tasksState: dict[str, str]
Review Comment:
Ah, makes sense. I would change the description of those facets though to
indicate more where they are used and how.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
