potiuk commented on PR #39520: URL: https://github.com/apache/airflow/pull/39520#issuecomment-2146578675
Yes. When you run tests in PR "selective" checks are run, but when you run them in main "all" tests are run. In this case, there is an inconsistenty between what is excluded and what is included. On one hand selective checks want to run `common.io` tests - because openlineage has some common.io import or the other way (whenever openlineage provider gets modified, we run tests for all providers that are cross-dependend on openlineage). But also we want to ignore `common.io` Look at the command executed: ``` Starting the tests with those pytest arguments: tests/providers/common/io tests/providers/common/sql tests/providers/dbt/cloud tests/providers/ftp tests/providers/mysql tests/providers/openlineage tests/providers/postgres tests/providers/sftp tests/providers/snowflake tests/providers/trino --verbosity=0 --strict-markers --durations=100 --maxfail=50 --color=yes --junitxml=/files/test_result-providers_common_io_common_sql-sqlite.xml --timeouts-order moi --setup-timeout=60 --execution-timeout=60 --teardown-timeout=60 --disable-warnings -rfEX --ignore=tests/system --ignore=tests/integration --warning-output-path=/files/warnings-providers_common_io_common_sql-sqlite.txt --ignore=helm_tests --with-db-init --no-cov --ignore=tests/providers/common/io --ignore=tests/providers/fab ``` From selective checks: ``` affected-providers-list-as-string = amazon common.io common.sql dbt.cloud ftp google mysql openlineage postgres sftp snowflake trino ``` From compatibility check we have `--ignore=tests/providers/common/io`. Apparently pytest overrides the ignore when we explicitly have `tests/providers/common/io` on the list of folders to disover tests in. The fix (https://github.com/apache/airflow/pull/40037) is to remove such provider from pytest args when it is also specified as `--ignore`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
