shahar1 commented on code in PR #39767:
URL: https://github.com/apache/airflow/pull/39767#discussion_r1610950987
##########
airflow/providers/google/cloud/hooks/vertex_ai/auto_ml.py:
##########
@@ -551,6 +551,8 @@ def create_auto_ml_forecasting_training_job(
is_default_version: bool | None = None,
model_version_aliases: list[str] | None = None,
model_version_description: str | None = None,
+ window_stride_length: [int] | None = None,
+ window_max_count: [int] | None = None,
Review Comment:
```suggestion
window_stride_length: int | None = None,
window_max_count: int | None = None,
```
##########
airflow/providers/google/cloud/hooks/vertex_ai/auto_ml.py:
##########
@@ -703,6 +705,10 @@ def create_auto_ml_forecasting_training_job(
:param sync: Whether to execute this method synchronously. If False,
this method will be executed in
concurrent Future and any downstream object will be immediately
returned and synced when the
Future has completed.
+ :window_stride_length: Optional. Step length used to generate input
examples. Every
+ ``window_stride_length`` rows will be used to generate a sliding
window.
+ window_max_count: Optional. Number of rows that should be used to
generate input examples. If the
+ total row count is larger than this number, the input data will be
randomly sampled to hit the count.
Review Comment:
```suggestion
:param window_stride_length: Optional. Step length used to generate
input examples. Every
``window_stride_length`` rows will be used to generate a sliding
window.
:param window_max_count: Optional. Number of rows that should be
used to generate input examples. If the
total row count is larger than this number, the input data will be
randomly sampled to hit the count.
```
##########
airflow/providers/google/cloud/hooks/vertex_ai/auto_ml.py:
##########
@@ -758,6 +764,8 @@ def create_auto_ml_forecasting_training_job(
is_default_version=is_default_version,
model_version_aliases=model_version_aliases,
model_version_description=model_version_description,
+ window_stride_length=window_stride_length,
+ window_max_count=window_stride_length,
Review Comment:
```suggestion
window_max_count=window_max_count,
```
##########
airflow/providers/google/cloud/operators/vertex_ai/auto_ml.py:
##########
@@ -220,6 +224,8 @@ def execute(self, context: Context):
model_display_name=self.model_display_name,
model_labels=self.model_labels,
sync=self.sync,
+ window_stride_length=self.window_stride_length,
+ window_max_count=self.window_stride_length,
Review Comment:
```suggestion
window_stride_length=self.window_stride_length,
window_max_count=self.window_max_count,
```
##########
airflow/providers/google/cloud/operators/vertex_ai/auto_ml.py:
##########
@@ -138,6 +138,8 @@ def __init__(
region: str,
impersonation_chain: str | Sequence[str] | None = None,
parent_model: str | None = None,
+ window_stride_length: [int] | None = None,
+ window_max_count: [int] | None = None,
Review Comment:
```suggestion
window_stride_length: int | None = None,
window_max_count: int | None = None,
```
##########
airflow/providers/google/cloud/operators/vertex_ai/auto_ml.py:
##########
@@ -170,6 +172,8 @@ def __init__(
self.quantiles = quantiles
self.validation_options = validation_options
self.budget_milli_node_hours = budget_milli_node_hours
+ self.window_stride_length=window_stride_length,
+ self.window_max_count=window_stride_length,
Review Comment:
```suggestion
self.window_stride_length=window_stride_length,
self.window_max_count=window_max_count,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
