josh-fell commented on code in PR #39767:
URL: https://github.com/apache/airflow/pull/39767#discussion_r1613655508


##########
airflow/providers/google/cloud/hooks/vertex_ai/auto_ml.py:
##########
@@ -703,6 +705,10 @@ def create_auto_ml_forecasting_training_job(
         :param sync: Whether to execute this method synchronously. If False, 
this method will be executed in
             concurrent Future and any downstream object will be immediately 
returned and synced when the
             Future has completed.
+        :param window_stride_length: Optional. Step length used to generate 
input examples. Every 
+        ``window_stride_length`` rows will be used to generate a sliding 
window.
+        :param window_max_count: Optional. Number of rows that should be used 
to generate input examples. If the 
+        total row count is larger than this number, the input data will be 
randomly sampled to hit the count.

Review Comment:
   ```suggestion
           :param window_stride_length: Optional. Step length used to generate 
input examples. Every 
               ``window_stride_length`` rows will be used to generate a sliding 
window.
           :param window_max_count: Optional. Number of rows that should be 
used to generate input examples. If the 
               total row count is larger than this number, the input data will 
be randomly sampled to hit the count.
   ```
   Small nit on [formatting the docstring 
params](https://sphinx-rtd-tutorial.readthedocs.io/en/latest/docstrings.html#an-example-class-with-docstrings)
 in the Sphinx RTD format for the [Python API 
docs](https://airflow.apache.org/docs/apache-airflow-providers-google/stable/_api/airflow/providers/google/cloud/hooks/vertex_ai/auto_ml/index.html#airflow.providers.google.cloud.hooks.vertex_ai.auto_ml.AutoMLHook.create_auto_ml_forecasting_training_job).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to