vincbeck commented on code in PR #39920:
URL: https://github.com/apache/airflow/pull/39920#discussion_r1619481276
##########
docs/apache-airflow-providers-amazon/executors/ecs-executor.rst:
##########
@@ -187,6 +187,13 @@ Then you can build your image by ``cd``-ing to the
directory with the Dockerfile
docker build -t my-airflow-image \
--build-arg aws_default_region=YOUR_DEFAULT_REGION .
+For users on Apple Silicon, you must specify the arch using ``docker buildx``:
Review Comment:
Could you please update batch executor documentation as well. It is done
here:
https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-amazon/executors/general.rst?plain=1#L68.
I wondered if we should not use this one in ECS executor as well? I guess
that's why we moved this section to a separate file? @syedahsn @o-nikolas
##########
docs/apache-airflow-providers-amazon/executors/ecs-executor.rst:
##########
@@ -187,6 +187,13 @@ Then you can build your image by ``cd``-ing to the
directory with the Dockerfile
docker build -t my-airflow-image \
--build-arg aws_default_region=YOUR_DEFAULT_REGION .
+For users on Apple Silicon, you must specify the arch using ``docker buildx``:
Review Comment:
But thanks for adding this section! :D Very helpful for Mac users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
