vincbeck commented on code in PR #39920:
URL: https://github.com/apache/airflow/pull/39920#discussion_r1620760860
##########
docs/apache-airflow-providers-amazon/executors/ecs-executor.rst:
##########
@@ -187,6 +187,13 @@ Then you can build your image by ``cd``-ing to the
directory with the Dockerfile
docker build -t my-airflow-image \
--build-arg aws_default_region=YOUR_DEFAULT_REGION .
+For users on Apple Silicon, you must specify the arch using ``docker buildx``:
Review Comment:
Valid points @Taragolis, I think the guide assumes that you are building the
image on the same machine you are running it but I guess you are right we can
add minor modifications to make it clear.
> So maybe instead of cover one case, better cover most of them with mention
that is important to build and run under the same architecture.
Covering all cases can be cumbersome (and especially, what are all cases?).
We could mention "that it is important to build and run under the same
architecture" and give as example the Apple Silicon
> And also would be nice to have a link to the Docker documentation.
Agree
##########
docs/apache-airflow-providers-amazon/executors/ecs-executor.rst:
##########
@@ -19,6 +19,8 @@
.. warning::
The ECS Executor is alpha/experimental at the moment and may be subject to
change without warning.
+.. |executorName| replace:: ECS
+.. |dockerfileLink| replace:: `here
<https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/executors/Dockerfile>`__
Review Comment:
Do we need to set `configKwargs`? `general.rst` uses it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
