mobuchowski commented on code in PR #39890:
URL: https://github.com/apache/airflow/pull/39890#discussion_r1621078161
##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -303,6 +306,14 @@ def heartbeat_callback(self, session: Session =
NEW_SESSION) -> None:
if dagrun_timeout and execution_time > dagrun_timeout:
self.log.warning("DagRun timed out after %s.",
execution_time)
+ # If process still runs after being marked as success, let it run
until configured overtime
+ # if there are configured listeners
+ if (
+ ti.state == TaskInstanceState.SUCCESS
Review Comment:
In this case, it's actually ran before state is formally changed in DB, so
that heartbeat mechanism does not apply.
https://github.com/apache/airflow/blob/7dc2b5243621f7a15ed1b44e1bf6eb81670f68d2/airflow/models/taskinstance.py#L3130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
