kacpermuda commented on code in PR #39890:
URL: https://github.com/apache/airflow/pull/39890#discussion_r1621883599
##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -303,6 +306,14 @@ def heartbeat_callback(self, session: Session =
NEW_SESSION) -> None:
if dagrun_timeout and execution_time > dagrun_timeout:
self.log.warning("DagRun timed out after %s.",
execution_time)
+ # If process still runs after being marked as success, let it run
until configured overtime
+ # if there are configured listeners
+ if (
+ ti.state == TaskInstanceState.SUCCESS
Review Comment:
Maybe it's worth mentioning it somehow in the yaml ? Right now we have:
> task_listener_timeout:
> description: |
> Maximum possible time (in seconds) that task listener will have for
their execution.
I know config is not the place to explain how airflow works, but after
reading just that i had the impression that this timeout will work for all
listener task related methods, not only success one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
