Lee-W commented on code in PR #39585:
URL: https://github.com/apache/airflow/pull/39585#discussion_r1621831179
##########
airflow/models/taskinstance.py:
##########
@@ -1580,13 +1581,39 @@ def _coalesce_to_orm_ti(*, ti: TaskInstancePydantic |
TaskInstance, session: Ses
@internal_api_call
@provide_session
-def _defer_task(
+def _defer_task_from_task_deferred(
ti: TaskInstance | TaskInstancePydantic, exception: TaskDeferred, session:
Session = NEW_SESSION
) -> TaskInstancePydantic | TaskInstance:
from airflow.models.trigger import Trigger
# First, make the trigger entry
trigger_row = Trigger.from_object(exception.trigger)
+ updated_ti = _defer_task(
+ ti=ti,
+ session=session,
+ trigger_row=trigger_row,
+ trigger_kwargs=exception.kwargs,
+ next_method=exception.method_name,
+ timeout=exception.timeout,
+ )
+
+ session.merge(updated_ti)
+ session.commit()
+ return updated_ti
+
+
+@internal_api_call
+@provide_session
+def _defer_task(
Review Comment:
Thanks for all your suggestions! I just refactored it a bit and everything
looks much better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
