Lee-W commented on code in PR #39585:
URL: https://github.com/apache/airflow/pull/39585#discussion_r1623847613
##########
airflow/models/taskinstance.py:
##########
@@ -1615,8 +1632,10 @@ def _defer_task(
ti.trigger_timeout = ti.start_date + execution_timeout
if ti.test_mode:
_add_log(event=ti.state, task_instance=ti, session=session)
- session.merge(ti)
- session.commit()
+
+ if exception is not None:
Review Comment:
I tested it locally. It raises an error if we commit here for the
start_trigger case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
