shahar1 commented on PR #39994: URL: https://github.com/apache/airflow/pull/39994#issuecomment-2143547551
> Hmmm. I am not sure (to be honest) how this would work ... But I think I have little clarity myself what I wanted to do there.. > > Question: could you explain in your words what this task is about :D ? Maybe we can get to common understanding :D I'll try to split it into two parts from my understanding: 1. In the first part of the original issue, the integration tests for Celery only utilize Redis as a broker and result backend. This PR addresses this issue by parameterizing the broker URL and running the same integration test for both Redis and Rabbitmq (it could be helpful for future alternatives if we decide to support them). 2. In the second part of the issue, you referred to a faulty caused by a version conflict between Celery and SQLAlchemy, and by creating an appropriate integration test, we could have discovered it in the CI. This PR doesn't address this issue (maybe it's a good time for a disclosure that I haven't touched the more "core" parts of Airflow components yet, so I might need more time to learn this area). I'd be happy if you could merge this one, and create a separate issue for the second part (if you think that it's still relevant and worth implementing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
