potiuk commented on PR #39994:
URL: https://github.com/apache/airflow/pull/39994#issuecomment-2143574999

   Ah... Now I know what the problem with my understanding was ... Actually the 
tests already supported both redis and rabbitmq by the very same 
parameterisation - so your change just organizes it a bit better by converting 
it in a map and extracting the constants. 
   
   There are two tests only that use the `_prepare_test_bodies` method and that 
did not change in your PR.
   
   The idea however was to run **all** the integration tests for celery in 
similar way - once with rabbitmq and once with redis. Likely by running two 
different integrations "celery-rabbitmq" , "celery-redis" - basically running 
the same tests. This would require to change the marker logic a BIT I think - 
because that is not currently possible/easy. 
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to