uranusjr commented on code in PR #40030:
URL: https://github.com/apache/airflow/pull/40030#discussion_r1625210434
##########
airflow/models/dag.py:
##########
@@ -800,10 +801,21 @@ def validate(self):
f"inconsistent schedule: timetable {self.timetable.summary!r} "
f"does not match schedule_interval {self.schedule_interval!r}",
)
+ self.validate_executor_field()
self.validate_schedule_and_params()
self.timetable.validate()
self.validate_setup_teardown()
+ def validate_executor_field(self):
+ for task in self.tasks:
+ if task.executor:
+ try:
+ ExecutorLoader.lookup_executor_name_by_str(task.executor)
+ except AirflowException:
Review Comment:
We should make the exception in `lookup_executor_name_by_str` more specific
and only catch that exception here. `AirflowException` is too broad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
