Lee-W commented on code in PR #40030:
URL: https://github.com/apache/airflow/pull/40030#discussion_r1629028872
##########
airflow/models/dag.py:
##########
@@ -800,10 +801,21 @@ def validate(self):
f"inconsistent schedule: timetable {self.timetable.summary!r} "
f"does not match schedule_interval {self.schedule_interval!r}",
)
+ self.validate_executor_field()
self.validate_schedule_and_params()
self.timetable.validate()
self.validate_setup_teardown()
+ def validate_executor_field(self):
+ for task in self.tasks:
+ if task.executor:
+ try:
+ ExecutorLoader.lookup_executor_name_by_str(task.executor)
+ except AirflowException:
Review Comment:
I agree with @uranusjr, and I notice we sometimes even wrap an explicit
exception and re-raise it with AirflowExecption in many places. We probably
could address it more.
But in this case, if we want to catch the narrow exception, we probably will
need to change
https://github.com/apache/airflow/blob/b03aa6caa076171337054c3adafe74e775d92453/airflow/executors/executor_loader.py#L198
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
