romsharon98 commented on code in PR #39936:
URL: https://github.com/apache/airflow/pull/39936#discussion_r1632169776
##########
helm_tests/other/test_git_sync_scheduler.py:
##########
@@ -211,6 +211,45 @@ def test_validate_if_ssh_params_are_added(self):
"secret": {"secretName": "ssh-secret", "defaultMode": 288},
} in jmespath.search("spec.template.spec.volumes", docs[0])
+ def test_validate_if_ssh_params_are_added_with_git_ssh_key(self):
+ docs = render_chart(
+ values={
+ "dags": {
+ "gitSync": {
+ "enabled": True,
+ "containerName": "git-sync-test",
+ "gitSshKey": "dummy-ssh-key",
+ "knownHosts": None,
+ "branch": "test-branch",
Review Comment:
right, now removed in all the tests I added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
