andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640808886
##########
airflow/www/views.py:
##########
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
datetime.timedelta(seconds=1)).replace(microsecond=0)
default_dag_run = conf.getint("webserver",
"default_dag_run_display_number")
- num_runs = www_request.args.get("num_runs", default=default_dag_run,
type=int)
Review Comment:
The change was made to ensure compatibility across different environments
and setups, particularly in testing scenarios where request.args might not
support keyword arguments. For me, I obtained a Keyword error while trying to
create my mock data. Although this does the same operation, some formdata does
not support keyword arguments. Correct me if I'm wrong tho :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
