aritra24 commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640919549
##########
airflow/www/views.py:
##########
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
datetime.timedelta(seconds=1)).replace(microsecond=0)
default_dag_run = conf.getint("webserver",
"default_dag_run_display_number")
- num_runs = www_request.args.get("num_runs", default=default_dag_run,
type=int)
Review Comment:
Ideally you don't want to change the code to fit the test, you'd be better
off changing the test to fit the code. I saw in the test you were creating a
custom class, it might be better to use the class that's actually passed into
the method. Perhaps some of the other tests might be using it, that should help
you out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
