dstandish commented on code in PR #40488: URL: https://github.com/apache/airflow/pull/40488#discussion_r1659402930
########## airflow/providers/amazon/CHANGELOG.rst: ########## @@ -33,13 +33,16 @@ Bug Fixes ~~~~~~~~~ * Reduce memory footprint of s3 key trigger (#40473) - - Decorator ``provide_bucket_name_async`` removed - * We do not need a separate decorator for async. The old one is removed and users can use ``provide_bucket_name`` - for coroutine functions, async iterators, and normal synchronous functions. - - Hook method ``get_file_metadata_async`` is now an async iterator - * Previously, the metadata objects were accumulated in a list. Now the objects are yielded as we page - through the results. To get a list you may use ``async for`` in a list comprehension. - - S3KeyTrigger avoids loading all positive matches into memory in some circumstances Review Comment: yeah i don't really have an opinion about it but let's just fix main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
