RNHTTR commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1662953768
##########
airflow/executors/base_executor.py:
##########
@@ -284,8 +289,11 @@ def trigger_tasks(self, open_slots: int) -> None:
self.log.info("queued but still running; attempt=%s
task=%s", attempt.total_tries, key)
continue
# Otherwise, we give up and remove the task from the queue.
- self.log.error(
- "could not queue task %s (still running after %d
attempts)", key, attempt.total_tries
+ self.task_context_logger.error(
+ "could not queue task %s (still running after %d
attempts)",
Review Comment:
What about...
> Could not queue task %s. Learn more:
https://airflow.apache.org/docs/apache-airflow/stable/troubleshooting.html#still-running-on-executor
And add a blurb in
[troubleshooting.rst](https://github.com/apache/airflow/blob/main/docs/apache-airflow/troubleshooting.rst)
explaining what the comment says (triggerer race condition or the task is soon
going to be marked failed)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
