RNHTTR commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1663327643
##########
airflow/executors/base_executor.py:
##########
@@ -284,8 +289,11 @@ def trigger_tasks(self, open_slots: int) -> None:
self.log.info("queued but still running; attempt=%s
task=%s", attempt.total_tries, key)
continue
# Otherwise, we give up and remove the task from the queue.
- self.log.error(
- "could not queue task %s (still running after %d
attempts)", key, attempt.total_tries
+ self.task_context_logger.error(
+ "could not queue task %s (still running after %d
attempts)",
Review Comment:
> I dont feel strongly confident describing it (since I am not sure how it
happens)
This is my problem too, which is why I'm hoping we can come up with
something more useful or just not surface this log. Usually when I encounter
this, I mostly ignore it and look for something else that's meaningful.
In my opinion, `executor reports task is currently running` is still tricky
to users. If I understand correctly, it's reporting the state of the task in,
for example, celery (that is, `running`), which is different than the Airflow
state of the task (`queued`). I think surfacing this log as written will only
confuse users more than if it didn't show up at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
